fix: add missing "Register Your Domains" section to ash.install scribe #2535
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ash.install --scribe` task was missing the "Register Your Domains" section that was manually added in #2533. This caused the documentation to be overwritten whenever `mix docs` or `mix check` ran. Also fixes a typo: "protocolc onsolidation" -> "protocol consolidation"
Contributor
|
🤦 I forgot that file was generated. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ash.installscribe generator so it's included when documentation is regeneratedThe
ash.install --scribetask generatesdocumentation/topics/advanced/manual-installation.md. The "Register Your Domains" section added in #2533 was added directly to the markdown file rather than to the generator, so it was being overwritten whenevermix docsormix checkran.Test plan
mix checkand verifymanual-installation.mdno longer shows unexpected changes