Skip to content

[Performance] Reduce unnecessary copying of strings and objects #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Performance] Reduce unnecessary copying of strings and objects #129

wants to merge 1 commit into from

Conversation

@marcomagdy
Copy link

@marcomagdy marcomagdy commented Nov 28, 2023

Description of changes:

This patch attempts to improve performance by doing the following:

  1. Remove an extra getenv call, which internally involve a bunch of string copying.
  2. Avoid default constructing the invocation_request object only to overwrite it later with the actual request. Instead use a reference.
  3. Avoid copying the request string when we can pass it by reference

Testing:

  • make test
  • make test-integ

Target (OCI, Managed Runtime, both):

Both

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@marcomagdy
[Performance] Reduce unnecessary copying of strings and objects
e4a7da9 
This patch attempts to improve performance by doing the following:
1. Remove an extra `getenv` call, which internally involve a bunch of
   string copying.
2. Avoid default constructing the `invocation_request` object only to
   overwrite it later with the actual request. Instead use a reference.
3. Avoid copying the request string when we can pass it by reference

Testing:
- make test
- make test-integ
@marcomagdy marcomagdy marked this pull request as ready for review November 28, 2023 20:05
@marcomagdy
Copy link
Author

marcomagdy commented Nov 28, 2023

FWIW, I wrote the native the client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@marcomagdy