Fix: Corrected Validation Logic and Exception Handling for validate.py and SamTemplateValidator#7983
Closed
Pranaykarvi wants to merge 6 commits intoaws:developfrom
Pranaykarvi:feature/fix-validation-bug
Closed
Fix: Corrected Validation Logic and Exception Handling for validate.py and SamTemplateValidator#7983Pranaykarvi wants to merge 6 commits intoaws:developfrom Pranaykarvi:feature/fix-validation-bug
validate.py and SamTemplateValidator#7983Pranaykarvi wants to merge 6 commits intoaws:developfrom
Pranaykarvi:feature/fix-validation-bug
Conversation
Contributor
|
Hi. Thanks for the contribution! It looks like you missed to commit the changes from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses and fixes a validation bug in the
SamTemplateValidatorand the associated CLI command used to validate AWS SAM templates. The following changes have been made:SamTemplateValidatorto handle localCodeUriandImageUriproperly by replacing them with fake S3 URIs for SAM translation.validate.pyfile where the region or credentials weren’t being handled correctly during SAM template validation.cli.pycommand to ensure the validation process is smooth and error-free when interacting with AWS services.Changes:
CodeUriandImageUriwith S3 URIs for correct SAM translation.How to test:
sam validatecommand with a sample SAM template to ensure that it correctly validates and processes localCodeUriandImageUri.lintcommand to ensure that SAM template linting works as expected.Related Issues:
Notes:
fixes #7973