Conversation
carreter
left a comment
carreter
left a comment
There was a problem hiding this comment.
Oops, probably left more comments than I should have... 😅
| return Alignment{}, err | ||
| } | ||
| parser.line++ | ||
| line := strings.TrimSpace(string(lineBytes)) |
There was a problem hiding this comment.
nit, style: Same as above, disambiguate this from parser.line.
There was a problem hiding this comment.
What does that mean exactly? What should be disambiguated?
There was a problem hiding this comment.
parser.line refers to the line number, while line refers to the line contents. IMO would help readability to make the difference explicit in the names.
| } | ||
|
|
||
| // ParseNext parsers the next read from a parser. Returns an error upon EOF. | ||
| func (parser *Parser) ParseNext() (Alignment, error) { |
There was a problem hiding this comment.
Please add some whitespace/comments to this to make it easier to read!
There was a problem hiding this comment.
Ah yes, I definitely need to do that. Lil hard to read right now.
Co-authored-by: Willow Carretero Chavez <sandiegobutterflies@gmail.com>
Co-authored-by: Willow Carretero Chavez <sandiegobutterflies@gmail.com>
Co-authored-by: Willow Carretero Chavez <sandiegobutterflies@gmail.com>
Co-authored-by: Willow Carretero Chavez <sandiegobutterflies@gmail.com>
|
What's the status of this? If it's ready for review, I'll take a look in the coming couple of days. |
|
Well I haven't updated it to merge into #339 , so a bit to go there. I think it basically works though. |
|
Alright, will give it a looksie tomorrow then! |
2 participants
This PR adds a sam file parser. Minimal functioning parser created, needs testing. Doing that next.
Not ready for merge.