feat(desktop): add search to the channel Add agents dialog - #8026
Draft
tomdmeredith wants to merge 1 commit into
Draft
tomdmeredith wants to merge 1 commit into
tomdmeredith wants to merge 1 commit into
Conversation
Pin a search box under the dialog title using the same modal search shell as the members sidebar and channel browser. It narrows the agent rows by name, description and system prompt, and the team chips by team text or any matching member, so searching for one agent still surfaces the team that would add it. Selections survive narrowing, Escape clears an active search before the next one closes the dialog, and the box resets when the dialog closes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Tom Meredith <tom.d.meredith@gmail.com>
🔐 Codex Security Review
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a search box to the channel "Add agents" dialog (
AddChannelBotDialog), pinned under the title so it stays put while the list scrolls. It uses the same modal search shell as the members sidebar and channel browser.onEscapeKeyDownbecause Radix's dismiss listener runs on the document in the capture phase, ahead of any input handler.ChooserDialogContentgains an optionalheaderAccessoryslot rendered full-width under the header; existing callers are unchanged.Independent of #8001 (Agents page search), so the two can land in either order. Closes #8003. Duplicates: none found in open issues or PRs.
Test plan
Automated (run locally):
desktop/src/features/agents/lib/personaChooserSearch.test.mjs: query tokenization and AND matching, persona fields, team matching via own text and via members, and orphaned member ids.desktop/tests/e2e/channels.spec.ts"add agents dialog search narrows agents and teams": binds the box by its accessible name and checks autofocus, searches by system-prompt text, checks a prior selection survives narrowing, a team-only hit is not an empty state, the empty state, Escape-to-clear then Escape-to-close, and that cancelling with a query still typed reopens with an empty box.pnpm typecheck,pnpm check,pnpm testgreen.Manual steps for the human check:
🤖 Generated with Claude Code