Partial revert of changes for Issue #209 - compiler warnings#317
Merged
igaztanaga merged 2 commits intoboostorg:developfrom Sep 6, 2025
Merged
Partial revert of changes for Issue #209 - compiler warnings#317igaztanaga merged 2 commits intoboostorg:developfrom
igaztanaga merged 2 commits intoboostorg:developfrom
Conversation
Issue boostorg#248 concerns reduced performance due to commit 0d5068a
Member
|
As suggested, PR #314 has been the chosen fix. |
Contributor
Author
|
This PR was intended to be complementary to PR #314, to get both benefits of resolving the warnings and the original performance. |
Contributor
Author
|
@igaztanaga Please reconsider this PR with the clarification that this is about reverting the performance regression. |
Member
|
Thanks for the explanation, I'll reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Issue #209 and Issue #248
PR #314 is possibly a better resolution to both of these issues: Original performance, compiler warnings resolved.
Tests are passing.