Skip to content

Changes request default's cancel_on_connection_lost to false#334

Merged
anarthal merged 2 commits intoboostorg:developfrom
anarthal:bugfix/setup-cancel-on-connection-lost
Oct 20, 2025
Merged

Changes request default's cancel_on_connection_lost to false#334
anarthal merged 2 commits intoboostorg:developfrom
anarthal:bugfix/setup-cancel-on-connection-lost

Conversation

@anarthal
Copy link
Collaborator

Changes request default constructor to set cancel_on_connection_lost to false, matching request::config's default initializer
Overwrites this flag to true for the setup request
Adds unit tests for the latter

Changes request default constructor to set cancel_on_connection_lost to false, matching request::config's default initializer
Overwrites this flag to true for the setup request
@anarthal
Copy link
Collaborator Author

This is a fix for #329, where I missed that the request constructor's default argument passes the flag values explicitly. I forgot to update this value, effectively rendering the PR ineffective in most cases. Apparently passing these flags explicitly is required because config is a nested type, rather than a standalone type.

I've also made sure to overwrite the flags for the setup request, so it's cancelled on error.

@anarthal anarthal requested a review from mzimbres October 17, 2025 14:29
@anarthal anarthal merged commit 42411be into boostorg:develop Oct 20, 2025
17 checks passed
@anarthal anarthal deleted the bugfix/setup-cancel-on-connection-lost branch October 20, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants