cli: Fix switch --mutate-in-place to work outside booted environment#1855
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Dec 17, 2025
Merged
cli: Fix switch --mutate-in-place to work outside booted environment#1855cgwalters merged 1 commit intobootc-dev:mainfrom
cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly refactors the --mutate-in-place logic to work outside of a fully booted ostree environment, which is a great improvement for use cases like Anaconda. The addition of integration tests for this scenario is also valuable. However, the change introduces a regression by removing the explicit check that prevents this command from running on an unsupported composefs backend. This would lead to a confusing error for users. My review includes a suggestion to re-introduce a check to ensure the command fails gracefully on unsupported backends.
Move the --mutate-in-place handling before get_storage() so it doesn't require a fully booted ostree environment. This enables use cases like Anaconda where we're chrooted into a non-booted system. Closes: bootc-dev#1854 Assisted-by: OpenCode (claude-sonnet-4-20250514) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
switch-mutate-in-place
branch
from
2fbbb83 to
283896e
Compare
henrywang
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the --mutate-in-place handling before get_storage() so it doesn't require a fully booted ostree environment. This enables use cases like Anaconda where we're chrooted into a non-booted system.
Closes: #1854
Assisted-by: OpenCode (claude-sonnet-4-20250514)