Conversation
erickhun
suggested changes
Mar 9, 2021
erickhun
left a comment
Contributor
There was a problem hiding this comment.
good catch @hamstu
Do you think we can we also change the composer version so it won't create issues with other services using the library?
I'll need to deploy the new version to packager once you merge it too
Contributor
Author
|
Thanks Eric! Good catch on the version. I'll push up that change. |
Contributor
Author
|
@erickhun I bumped the minor version. Are you able to take care of deploying it? |
Contributor
Author
|
cc @josem |
Member
|
Ah nice, thanks so much for this! 🚀 |
Contributor
|
@hamstu @josem I've just published it in packagist: https://packagist.org/packages/bufferapp/php-bufflog#0.2.0 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a subtle, but improper letter case.
This might be why we can't use --classmap-authoritative when dumping the autolaod, as it would conflict with the declared namespace.