Skip to content

Fix uppercase L in BuffLog namespace#23

Merged
hamstu merged 2 commits into
masterfrom
fix-case
Mar 9, 2021
Merged

Fix uppercase L in BuffLog namespace#23
hamstu merged 2 commits into
masterfrom
fix-case

Conversation

@hamstu

@hamstu hamstu commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

Fix a subtle, but improper letter case.

This might be why we can't use --classmap-authoritative when dumping the autolaod, as it would conflict with the declared namespace.

@hamstu hamstu requested a review from erickhun February 2, 2021 23:24

@erickhun erickhun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @hamstu

Do you think we can we also change the composer version so it won't create issues with other services using the library?

I'll need to deploy the new version to packager once you merge it too

@hamstu

hamstu commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

Thanks Eric! Good catch on the version. I'll push up that change.

@hamstu

hamstu commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

@erickhun I bumped the minor version. Are you able to take care of deploying it?

@erickhun erickhun self-requested a review March 9, 2021 20:08

@erickhun erickhun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hamstu I'll deploy this one tomorrow on packagist - will let you know when it's done

@hamstu

hamstu commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

cc @josem

@hamstu hamstu merged commit 019c3a4 into master Mar 9, 2021
@hamstu hamstu deleted the fix-case branch March 9, 2021 23:17
@josem

josem commented Mar 10, 2021

Copy link
Copy Markdown
Member

Ah nice, thanks so much for this! 🚀

@erickhun

Copy link
Copy Markdown
Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants