fix: keep the default tolerance key when upper casing column names - #572
Merged
fdosani merged 2 commits intoSep 24, 2026
Merged
Conversation
|
|
fdosani
approved these changes
Sep 24, 2026
fdosani
left a comment
fdosani
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing/flagging this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnowflakeCompare normalizes tolerance dict keys with
case_mode="upper", which turned the special"default"key into"DEFAULT".get_column_tolerancelooks up"default", which was then filled in as 0.0, so a dict like{"COL1": 0.1, "default": 0.5}silently compared every other column exactly. This skips upper casing for the"default"key and extendstest_case_sensitivityto cover it.Checks run:
pytest tests/test_base.py tests/test_pandas.py tests/test_polars.py(the only failures are two pre-existing Windows path/encoding tests that also fail on main),ruff checkandruff format --checkon the changed files.