Skip to content

Add validation for --benchmark-samples to prevent crash with zero value#3056

Merged
horenmar merged 4 commits intocatchorg:develfrom
qerased:fix-benchmark-samples-zero
Jan 2, 2026
Merged

Add validation for --benchmark-samples to prevent crash with zero value#3056
horenmar merged 4 commits intocatchorg:develfrom
qerased:fix-benchmark-samples-zero

Conversation

@qerased
Copy link
Copy Markdown
Contributor

@qerased qerased commented Dec 20, 2025

This PR adds validation for --benchmark-samples=0 to prevent a crash,
adds an automated self-test, and updates approval baselines.

PR is based on the request #3041
Fixes #3040

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.03%. Comparing base (9709163) to head (8575d33).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3056      +/-   ##
==========================================
- Coverage   91.03%   91.03%   -0.00%     
==========================================
  Files         202      202              
  Lines        8727     8736       +9     
==========================================
+ Hits         7944     7952       +8     
- Misses        783      784       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@qerased
Copy link
Copy Markdown
Contributor Author

qerased commented Dec 20, 2025

also added test for "could not parse ... as benchmark samples" return

@horenmar
Copy link
Copy Markdown
Member

horenmar commented Jan 2, 2026

Thanks

also added test for "could not parse ... as benchmark samples" return

👍

@horenmar horenmar merged commit b66b893 into catchorg:devel Jan 2, 2026
77 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants