Skip to content

fix(clerk-js): Checkout CTAs to not display payment of zero amount #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Apr 25, 2025

Description

After

image

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:
@panteliselef panteliselef requested review from aeliox and a team April 25, 2025 15:50
@panteliselef panteliselef self-assigned this Apr 25, 2025
Copy link

changeset-bot bot commented Apr 25, 2025

🦋 Changeset detected

Latest commit: 9893154

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/types Patch
@clerk/clerk-js Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 4:40pm
@aeliox
Copy link
Contributor

aeliox commented Apr 25, 2025

Let's change this to Subscribe instead of Finish Checkout

@panteliselef panteliselef merged commit 115601d into main Apr 25, 2025
33 checks passed
@panteliselef panteliselef deleted the elef/com-589-update-checkout-buttons-from-pay-0-to-finish-checkout branch April 25, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants