Grpc transcoding supports preserve proto name #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiwzhang
force-pushed
the
preserve_proto_name
branch
from
1194c4b to
ecac98d
Compare
|
Fixes #682 |
JLXIA
reviewed
Sep 3, 2019
| ok(ApiManager::verify_http_json_response($response1, | ||
| {'shelfId'=>'100', }), "The shelf_id 1 was echoed successfully."); | ||
| ok(ApiManager::verify_http_json_response($response2, | ||
| {'shelfId'=>'100', }), "The shelfId 2 was echoed successfully."); |
|
|
||
| ok(ApiManager::verify_http_json_response($response1, | ||
| {'shelfId'=>'100', }), "The shelf_id 1 was echoed successfully."); | ||
| ok(ApiManager::verify_http_json_response($response2, |
There was a problem hiding this comment.
-> 1, to keep it consistent with the description?
Same for the following one.
| @@ -177,6 +177,9 @@ ngx_esp_request_ctx_s::ngx_esp_request_ctx_s(ngx_http_request_t *r, | |||
| if (lc->esp->get_always_print_primitive_fields()) { | |||
| json_print_options.always_print_primitive_fields = true; | |||
| } | |||
| if (lc->esp->get_preserve_proto_field_names()) { | |||
| json_print_options.preserve_proto_field_names = true; | |||
There was a problem hiding this comment.
So, the transcoding lib does support this feature, what needs to be done here is just pass in the configuration?
Should we do this for CloudESF as well?
nareddyt
previously approved these changes
Sep 3, 2019
JLXIA
approved these changes
Sep 3, 2019
|
which release contains this fix? I just tried latest version 1.43.0 it does not support it yet |
|
From our release note, it has been included since 1.39.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a flag in start_esp --transcoding_preserve_proto_field_names. If it is true, grpc transcoding will preserve proto names.