Skip to content

Adds support for waitForEvent step type #8981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Caio-Nogueira
Copy link
Contributor

@Caio-Nogueira Caio-Nogueira commented Apr 16, 2025

Fixes WOR-628.

This PR adds support the waitForEvent step to be shown in the wrangler workflows instances describe command


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: No addition was introduced here. Just additional information in an existing command.
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a patch change
@Caio-Nogueira Caio-Nogueira requested a review from a team as a code owner April 16, 2025 17:14
Copy link

changeset-bot bot commented Apr 16, 2025

🦋 Changeset detected

Latest commit: efcd2ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Caio-Nogueira Caio-Nogueira force-pushed the feat/workflows-waitForEvent-details branch 2 times, most recently from 2942434 to 834cb8b Compare April 16, 2025 17:15
@Caio-Nogueira Caio-Nogueira added the e2e Run wrangler + vite-plugin e2e tests on a PR label Apr 16, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 16, 2025
Copy link
Contributor

github-actions bot commented Apr 16, 2025

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-wrangler-8981
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-cloudflare-workers-bindings-extension-8981 -O ./cloudflare-workers-bindings-extension.0.0.0-v65c4f5432.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v65c4f5432.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-create-cloudflare-8981 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-cloudflare-kv-asset-handler-8981

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-miniflare-8981

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-cloudflare-pages-shared-8981

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-cloudflare-unenv-preset-8981

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-cloudflare-vite-plugin-8981

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-cloudflare-vitest-pool-workers-8981

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-cloudflare-workers-editor-shared-8981

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-cloudflare-workers-shared-8981

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14521571728/npm-package-cloudflare-workflows-shared-8981

Note that these links will no longer work once the GitHub Actions artifact expires.

Copy link
Contributor

These changes have been automatically backported to Wrangler v3 🎉 You can view the automatically updated PR at v3-maintenance...v3-maintenance-8981. Please check that PR for correctness, and make sure it's merged after this one. Thank you for helping us keep Wrangler v3 supported!

@Caio-Nogueira Caio-Nogueira force-pushed the feat/workflows-waitForEvent-details branch from 834cb8b to c8987e6 Compare April 17, 2025 10:08
@Caio-Nogueira Caio-Nogueira force-pushed the feat/workflows-waitForEvent-details branch from c8987e6 to efcd2ab Compare April 17, 2025 17:41
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR
4 participants