Skip to content

Extra extensions directories - #694

Merged
code-asher merged 5 commits into
masterfrom
feature/extra-extensions-directories
May 19, 2019
Merged

Extra extensions directories#694
code-asher merged 5 commits into
masterfrom
feature/extra-extensions-directories

Conversation

@code-asher

@code-asher code-asher commented May 19, 2019

Copy link
Copy Markdown
Member
  • Add flag for overriding builtin extension directory.
  • Add flag to specify extra builtin extension directories.
  • Add flag to specify extra user extension directories.

Fixes #693.

The extra directories aren't used yet, just available from the
environment service and to the shared process.
@code-asher
code-asher requested a review from kylecarbs as a code owner May 19, 2019 22:02
@code-asher code-asher changed the title Feature/extra extensions directories May 19, 2019
@code-asher
code-asher merged commit aa1474b into master May 19, 2019
@code-asher
code-asher deleted the feature/extra-extensions-directories branch May 19, 2019 22:58
@ammario

ammario commented May 19, 2019

Copy link
Copy Markdown
Member

Amazing Asher 🤸🏽‍♂️

andreimc added a commit to devonlineco/code-server that referenced this pull request May 22, 2019
* upstream/master:
  Show hidden files by default
  Fix human readable byte size when zero
  Expose actions registry (coder#701)
  Set NODE_ENV and VERSION when building (coder#700)
  Don't try to create builtin extensions directory
  Suppress "disconnected" notification on extension host
  Extra extensions directories (coder#694)
  Updated Data Directory Flag (coder#664)
  Remove broken links (coder#671)
code-asher added a commit that referenced this pull request Jun 19, 2019
* Allow setting paths for builtin exts and extra dirs

The extra directories aren't used yet, just available from the
environment service and to the shared process.

* Utilize extra builtin extensions path

* Utilize extra extensions directory

* Fix cached mtimes for extra extension dirs

* Simplify extension cache equality check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants