🤖 refactor: reuse standard task report reminders#2993
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 817568d10b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
817568d to
e404a5e
Compare
|
@codex review Please take another look. |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
This follow-up to #2986 keeps the existing
awaiting_reportrecovery behavior but trims one special case: waiter-triggered recovery now reuses the standard completion reminder instead of carrying a separate waiter-only prompt variant.Background
PR #2986 introduced a few paths that can re-prompt an
awaiting_reporttask. The waiter-specific reminder text and enum branch were the odd ones out, because they duplicated the same completion-tool guidance with different copy. Reusing the normal reminder keeps the recovery path while simplifying the state machine.Implementation
awaiting_reporttasks, but now reuses the default completion reminder path"waiter"completion-recovery reason and prompt stringwaitForAgentReport()no longer emits distinct waiter-only reminder copyValidation
bun test src/node/services/taskService.test.tsmake static-checkRisks
Low. This keeps the waiter-side recovery hook intact; it only removes the separate waiter-only reminder variant.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$146.35