Skip to content

🤖 refactor: reuse standard task report reminders#2993

Merged
ammario merged 1 commit intomainfrom
refactor/passive-task-report-waits
Mar 17, 2026
Merged

🤖 refactor: reuse standard task report reminders#2993
ammario merged 1 commit intomainfrom
refactor/passive-task-report-waits

Conversation

@ammar-agent
Copy link
Copy Markdown
Collaborator

@ammar-agent ammar-agent commented Mar 17, 2026

Summary

This follow-up to #2986 keeps the existing awaiting_report recovery behavior but trims one special case: waiter-triggered recovery now reuses the standard completion reminder instead of carrying a separate waiter-only prompt variant.

Background

PR #2986 introduced a few paths that can re-prompt an awaiting_report task. The waiter-specific reminder text and enum branch were the odd ones out, because they duplicated the same completion-tool guidance with different copy. Reusing the normal reminder keeps the recovery path while simplifying the state machine.

Implementation

  • waiter-triggered recovery still nudges awaiting_report tasks, but now reuses the default completion reminder path
  • dropped the now-unused "waiter" completion-recovery reason and prompt string
  • added a regression test that proves waitForAgentReport() no longer emits distinct waiter-only reminder copy

Validation

  • bun test src/node/services/taskService.test.ts
  • make static-check

Risks

Low. This keeps the waiter-side recovery hook intact; it only removes the separate waiter-only reminder variant.


Generated with mux • Model: openai:gpt-5.4 • Thinking: xhigh • Cost: $146.35

@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 817568d10b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammar-agent ammar-agent force-pushed the refactor/passive-task-report-waits branch from 817568d to e404a5e Compare March 17, 2026 02:03
@ammar-agent ammar-agent changed the title 🤖 refactor: keep task waits passive during report recovery Mar 17, 2026
@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

Please take another look.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammario ammario merged commit 3d28399 into main Mar 17, 2026
24 checks passed
@ammario ammario deleted the refactor/passive-task-report-waits branch March 17, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants