Skip to content
This repository was archived by the owner on Jan 17, 2021. It is now read-only.

Add option insiders with env-settings - #40

Closed
orenc17 wants to merge 4 commits into
coder:env-settingsfrom
orenc17:env-settings
Closed

Add option insiders with env-settings#40
orenc17 wants to merge 4 commits into
coder:env-settingsfrom
orenc17:env-settings

Conversation

@orenc17

@orenc17 orenc17 commented Apr 22, 2019

Copy link
Copy Markdown

This adds the option to use VSCode Insiders default configuration without setting the environment variables
@orenc17 orenc17 mentioned this pull request Apr 22, 2019
Closed
@ammario

ammario commented Apr 22, 2019

Copy link
Copy Markdown
Member

Could you explain why the added complexity to the code and API is justified, over just the solution in #39 .
@orenc17

orenc17 commented Apr 22, 2019

Copy link
Copy Markdown
Author

using environment isn't user friendly in my opinion
plus i don't think the average user knows where VSCode keeps its configurations
@ammario

ammario commented Apr 22, 2019

Copy link
Copy Markdown
Member

Another problem is we don't want users doing sshcode --insiders all the time. I agree that environment variables by themselves aren't friendly to the average user, but I also explain how to configure for VS Code Insiders on the README. I think that's good enough education on how to do this.
@ammario
ammario force-pushed the env-settings branch 2 times, most recently from e889cd7 to 7f1fcdb Compare April 22, 2019 20:02
@orenc17

orenc17 commented Apr 22, 2019

Copy link
Copy Markdown
Author

I can agree with that, i do believe that you could use 1 variable instead of 2
@orenc17 orenc17 closed this Apr 22, 2019
@orenc17
orenc17 deleted the env-settings branch April 22, 2019 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@orenc17 @ammario