Conversation
|
This doesn't seem to build right now. |
|
Well, this was a weird "it works on my computer", after a |
652caa3 to
fc46e5e
Compare
|
The CI fails because $ make rustfmt
cargo fmt --all -- --check --config fn_single_line=true,control_brace_style=ClosingNextLine
Warning: can't set `fn_single_line = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_indent = Block`, unstable features are only available in nightly channel.
Warning: can't set `control_brace_style = ClosingNextLine`, unstable features are only available in nightly channel. |
|
There are failing tests. |
|
Those tests also seems to fail on the master branch. |
I'm a bit worried if this will break compatibility with old state files. |
I updated the code to include a proper state saving/restoring. Now it's able to save and load states from before and after this PR. |
It's a mostly 1-1 migration to rust,
except for the alarm, instead of storing the full date, just store and compare the hour/minute/second.There are multiple parts of the code that I didn't understand or could be improved, but I decided to do a simple migration for now, to make this review as simple as possible.