Preserve OAuth projection during config onboarding - #705
Merged
TheGreatAxios merged 3 commits intoAug 28, 2026
Merged
Conversation
TheGreatAxios
commented
Aug 28, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Onboarding preserves OAuth projection semantics across config reloads.
No findings.
TheGreatAxios
commented
Aug 28, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Records on UnconfiguredConfig whether the settings source was a CLI --config path or a programmatic globalSettingsPath override, so the onboarding reload re-passes --config and only suppresses home OAuth-profile projection when the caller was programmatic.
No findings.
Notes
- Merge this before #706.
git merge-tree --write-treereports a content conflict insrc/tui/onboarding.ts:45-55: #706 keeps theoverridesSettingsPathgate and swaps inisProgrammaticSettingsOverride, which still returns true for any distinct--configfile and so does not fix this bug. Resolve in favour of this branch's provenance logic and drop #706'sisProgrammaticSettingsOverrideimport.src/config/index.tsmerges clean; #707 shares no files. src/tui/onboarding.ts:47— when bothcliConfigPathandprogrammaticSettingsPathare set the reload passes the CLI path asglobalSettingsPath; harmless sinceloadConfigonly checks forundefinedand--configwins, and the combination is test-only.- Checks:
bun run typecheck,bun run lint,bun test src/config.test.ts src/tui/onboarding.test.ts(76 pass). Withorigin/main:src/tui/onboarding.tsswapped in, the new tests fail withSelected provider "xai/work" is not configured in settings— the reported bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--configcomposed with home OAuth profiles while programmatic settings remain isolated.Verification
bun run checkpasses.bun test src/config.test.ts src/tui/onboarding.test.tspasses with 76 tests.Fixes CL-7116