CL-5971: Shell mock wants — component API additions - #17
Merged
TheGreatAxios merged 7 commits intoAug 14, 2026
Conversation
TheGreatAxios
marked this pull request as ready for review
August 14, 2026 00:27
Base automatically changed from
cl-5940-toast-system
to
cl-5879-shell-mock-v2-react-ui
August 14, 2026 00:28
TheGreatAxios
force-pushed
the
cl-shell-mock-wants
branch
from
August 14, 2026 00:28
6d83451 to
f07f180
Compare
ActionControl hardcoded Button size="md". A stage empty-state embedded under a top bar wants its actions at the same sm scale as the bar around it, so actionSize is now threaded through, defaulting to md.
Unselected chips rendered as border-transparent bg-transparent — bare text with no affordance that they are clickable. The unselected state now carries the same border-border ring the selected state's card treatment sits inside, so both states read as one pill family.
No slot existed for a leading scope chip in the input row or a keyboard-hint legend under the results. inputAccessory renders inside the input row, ahead of the input; footer renders as a pinned strip below the results (independent of the load-more control).
SidebarRailItem carried no way to attach a DOM id or data-* attribute to a specific item, so a consumer had no hook to target one rail button (a tour, a spotlight). Extra item keys now spread onto the rendered button, and the item's id renders as the button's DOM id.
Generic versions of Workbench's generative-UI block frame and risk callout: a zero-radius bordered card with a pulse-dot header, and a tone-driven risk label. Adds --ok/--warn theme tokens (light/dark, matching Workbench's app.css) since the risk tones need colours the theme did not carry yet.
rounded-md and bg-primary/10 were hardcoded utilities a consumer's own stylesheet could not out-cascade without matching specificity. The row now reads --sidebar-row-radius and --sidebar-row-selected-bg (defined in theme.css, defaulting to the previous values), so a consumer can override them once on a scoping element instead of fighting the utility.
The shell mock's only approve card renders its risk line in --warn regardless of level — there's no green "all clear" treatment for risk. Map low to --muted-foreground so only medium/high draw the eye; --ok stays reserved for step/delivery "done" states.
TheGreatAxios
force-pushed
the
cl-shell-mock-wants
branch
from
August 14, 2026 00:29
f07f180 to
10dab71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RichEmptyState: optionalactionSizeto match denser host chromeFilterChip: visible border on the unselected stateCommandPalette:inputAccessoryandfooterslotsSidebarRailItem: forwards rest props (per-itemdata-*, render id)BlockCardandRiskBadgeprimitives, lifted from Workbench's chat-ui, with--ok/--warntokensSidebarItemRow: row radius and selected background exposed as tokensLinear: CL-5971