Make CI structural match local check:structural (CL-7281) - #539
Merged
TheGreatAxios merged 3 commits intoAug 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local
check:structuralalready rancheck:report-error; CI'sstructuraljob enumerated a shorter list and skipped it, so main could fail the gate that localbun run checkclaims to enforce.This PR routes the five unreported catch sites through
reportErrorso the gate is green, then points CI atbun run check:structuralso the two lists cannot drift.Catch sites
reportError(was log-only).runBulkOperationcallreportErroreven when the caller omitsonError. The runner lives inbulk-run.tsso./clientcan still re-export the eligibility helpers without pulling@intx/loginto a browser bundle.reportErrorin the catch itself (helpers wrappingreportErrorare invisible to the check).CI
The
structuraljob now runsbun run check:structural— the same chain as local, includingcheck:report-errorand the check-script self-tests. A job-shape test pins that CI does not re-enumerate the sub-checks.check:packagesis no longer in the structural job (it was never in localcheck:structural; it remainsbun run check:all).Linear
https://linear.app/abklabs/issue/CL-7281/checkreport-error-runs-locally-but-not-in-ci-and-fails-on-main-today