Fix #14826 valueflow: forward lifetimes through array and member subobjects#8636
Conversation
|
I also ran tools/test-my-pr on 300 packages and found no diff with main. |
|
We should probably have a ticket for this. |
|
@chrchr-github I tried to trigger the code from tickets: 12407, 13331, 13568, 14329. Unfortunately, this PR fixed none of them so I think we need a new ticket. |
Thanks for checking, I have created https://trac.cppcheck.net/ticket/14826 |
@francois-berder can you please update the PR title. |
francois-berder
changed the title
…bjects Signed-off-by: Francois Berder <fberder@outlook.fr>
francois-berder
force-pushed
the
improve-valueflowforwardlifetime
branch
from
e3afc01 to
ce643cb
Compare
Done |
| std::vector<const Token*> parents = getLhsLifetimeParents(parent->astOperand1(), settings.library); | ||
| for (const Token *p : parents) |
There was a problem hiding this comment.
I suggest
| std::vector<const Token*> parents = getLhsLifetimeParents(parent->astOperand1(), settings.library); | |
| for (const Token *p : parents) | |
| for (const Token *p : getLhsLifetimeParents(parent->astOperand1(), settings.library)) |
…nd member subobjects
3 participants
No description provided.