Update tools/MT-Unsafe.py to find all the unsafe functions listed in#8642
Draft
andrew-aitchison wants to merge 4 commits into
Draft
Update tools/MT-Unsafe.py to find all the unsafe functions listed in#8642andrew-aitchison wants to merge 4 commits into
andrew-aitchison wants to merge 4 commits into
Conversation
man elf_flagelf Also update addons/threadsafety.py to include these functions. This man page lists several unsafe functions on one line.
Collaborator
|
I would like that the PR title is not chopped like this. it wouldn't hurt with a line in releasenotes to mention this improvement. testing: I am not sure what we can test but feel free to create a regression test if you can. Provide a made up input to MT-Unsafe.py and check that it outputs certain symbols? |
Contributor
Author
|
Title fixed. |
Contributor
Author
I have an input for MT-Unsafe.py and an expected output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tools/MT-Unsafe.py to find all the unsafe functions listed in
man elf_flagelfUpdate addons/threadsafety.py to include these functions.