csskit_source_finder: Don't find visitable nodes that just visit children - #1199
Merged
keithamus merged 1 commit intoJun 11, 2026
Conversation
…dren Currently csskit_source_finder's find_visitable_nodes function returns all nodes which derive(Visitable). This includes those that `visit(children)`, despite those nodes never needing to emit a `visit_<ty>` method, as they never call it. This change ensures those types are skipped, so css_ast doesn't emit those visit methods, as they're never called!
keithamus
enabled auto-merge (squash)
June 11, 2026 21:36
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
keithamus
deleted the
csskit-source-finder-don-t-find-visitable-nodes-that-just-visit-children
branch
June 11, 2026 21:44
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
## [0.0.25] - 2026-06-12 ### Other Changes - Update cargo deps (#1189) ([#1189](#1189)) - Push allocator-api2 back to 2.21 due to bumpalo (#1191) ([#1191](#1191)) - Fuzz: Try setting up a fuzzing suite (#1201) ([#1201](#1201)) ### Css_ast - css_ast: Avoid hanging on `={-->}` input. (#1183) ([#1183](#1183)) - Regenerate css_ast/src/values from csswg drafts (#1184) ([#1184](#1184)) - css_ast: Use assert_parse! closure macro variant in tests. (#1196) ([#1196](#1196)) - cssast/csskit_derives: Add new FeatureMetadata system (#1197) ([#1197](#1197)) - csskit_derives/css_ast: make derive(IntoCursor) work with generics (#1200) ([#1200](#1200)) - css_ast: Implement a NonEmpty generic (#1202) ([#1202](#1202)) ### Css_parse - css_parse: Ensure buffer is refilled if skipping past a whole buffer (#1180) ([#1180](#1180)) - css_parse: Impl ToSpan for Comparison (#1190) ([#1190](#1190)) - Impl Display for Comparison (#1193) ([#1193](#1193)) - css_parse: Improve assert_parse! macros to use a block/closure (#1194) ([#1194](#1194)) ### Csskit - csskit: improve json output for subcommands (#1182) ([#1182](#1182)) - chore(deps): update dependencies (patch) (#1185) ([#1185](#1185)) ### Csskit_derives - csskit_derives: Ensure generics expect Peek when using it. (#1198) ([#1198](#1198)) ### Csskit_source_finder - csskit_source_finder: Don't find visitable nodes that just visit children (#1199) ([#1199](#1199)) ### Csskit_vscode - chore(deps): update dependency @vscode/test-electron to v3 (#1192) ([#1192](#1192)) [forcebuild]
Merged
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
## [0.0.25] - 2026-06-12 ### Other Changes - Update cargo deps (#1189) ([#1189](#1189)) - Push allocator-api2 back to 2.21 due to bumpalo (#1191) ([#1191](#1191)) - Fuzz: Try setting up a fuzzing suite (#1201) ([#1201](#1201)) ### Css_ast - css_ast: Avoid hanging on `={-->}` input. (#1183) ([#1183](#1183)) - Regenerate css_ast/src/values from csswg drafts (#1184) ([#1184](#1184)) - css_ast: Use assert_parse! closure macro variant in tests. (#1196) ([#1196](#1196)) - cssast/csskit_derives: Add new FeatureMetadata system (#1197) ([#1197](#1197)) - csskit_derives/css_ast: make derive(IntoCursor) work with generics (#1200) ([#1200](#1200)) - css_ast: Implement a NonEmpty generic (#1202) ([#1202](#1202)) ### Css_parse - css_parse: Ensure buffer is refilled if skipping past a whole buffer (#1180) ([#1180](#1180)) - css_parse: Impl ToSpan for Comparison (#1190) ([#1190](#1190)) - Impl Display for Comparison (#1193) ([#1193](#1193)) - css_parse: Improve assert_parse! macros to use a block/closure (#1194) ([#1194](#1194)) ### Csskit - csskit: improve json output for subcommands (#1182) ([#1182](#1182)) - chore(deps): update dependencies (patch) (#1185) ([#1185](#1185)) ### Csskit_derives - csskit_derives: Ensure generics expect Peek when using it. (#1198) ([#1198](#1198)) ### Csskit_source_finder - csskit_source_finder: Don't find visitable nodes that just visit children (#1199) ([#1199](#1199)) ### Csskit_vscode - chore(deps): update dependency @vscode/test-electron to v3 (#1192) ([#1192](#1192))
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 13, 2026
## [0.0.25] - 2026-06-13 ### Other Changes - Update cargo deps (#1189) ([#1189](#1189)) - Push allocator-api2 back to 2.21 due to bumpalo (#1191) ([#1191](#1191)) - Fuzz: Try setting up a fuzzing suite (#1201) ([#1201](#1201)) ### Css_ast - css_ast: Avoid hanging on `={-->}` input. (#1183) ([#1183](#1183)) - Regenerate css_ast/src/values from csswg drafts (#1184) ([#1184](#1184)) - css_ast: Use assert_parse! closure macro variant in tests. (#1196) ([#1196](#1196)) - cssast/csskit_derives: Add new FeatureMetadata system (#1197) ([#1197](#1197)) - csskit_derives/css_ast: make derive(IntoCursor) work with generics (#1200) ([#1200](#1200)) - css_ast: Implement a NonEmpty generic (#1202) ([#1202](#1202)) ### Css_lexer - fuzz: early return atom functions when given non-atom tokens (#1206) ([#1206](#1206)) - fuzz(css_lexer): ensure REPLACEMENT_CHARACTER is appended in small idents (#1213) ([#1213](#1213)) ### Css_parse - css_parse: Ensure buffer is refilled if skipping past a whole buffer (#1180) ([#1180](#1180)) - css_parse: Impl ToSpan for Comparison (#1190) ([#1190](#1190)) - Impl Display for Comparison (#1193) ([#1193](#1193)) - css_parse: Improve assert_parse! macros to use a block/closure (#1194) ([#1194](#1194)) ### Csskit - csskit: improve json output for subcommands (#1182) ([#1182](#1182)) - chore(deps): update dependencies (patch) (#1185) ([#1185](#1185)) ### Csskit_derives - csskit_derives: Ensure generics expect Peek when using it. (#1198) ([#1198](#1198)) ### Csskit_source_finder - csskit_source_finder: Don't find visitable nodes that just visit children (#1199) ([#1199](#1199)) ### Csskit_vscode - chore(deps): update dependency @vscode/test-electron to v3 (#1192) ([#1192](#1192)) - fix(deps): update dependency esbuild to v0.28.1 [security] (#1210) ([#1210](#1210)) [forcebuild]
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 13, 2026
## [0.0.25] - 2026-06-13 ### Other Changes - Update cargo deps (#1189) ([#1189](#1189)) - Push allocator-api2 back to 2.21 due to bumpalo (#1191) ([#1191](#1191)) - Fuzz: Try setting up a fuzzing suite (#1201) ([#1201](#1201)) ### Css_ast - css_ast: Avoid hanging on `={-->}` input. (#1183) ([#1183](#1183)) - Regenerate css_ast/src/values from csswg drafts (#1184) ([#1184](#1184)) - css_ast: Use assert_parse! closure macro variant in tests. (#1196) ([#1196](#1196)) - cssast/csskit_derives: Add new FeatureMetadata system (#1197) ([#1197](#1197)) - csskit_derives/css_ast: make derive(IntoCursor) work with generics (#1200) ([#1200](#1200)) - css_ast: Implement a NonEmpty generic (#1202) ([#1202](#1202)) ### Css_lexer - fuzz: early return atom functions when given non-atom tokens (#1206) ([#1206](#1206)) - fuzz(css_lexer): ensure REPLACEMENT_CHARACTER is appended in small idents (#1213) ([#1213](#1213)) ### Css_parse - css_parse: Ensure buffer is refilled if skipping past a whole buffer (#1180) ([#1180](#1180)) - css_parse: Impl ToSpan for Comparison (#1190) ([#1190](#1190)) - Impl Display for Comparison (#1193) ([#1193](#1193)) - css_parse: Improve assert_parse! macros to use a block/closure (#1194) ([#1194](#1194)) ### Csskit - csskit: improve json output for subcommands (#1182) ([#1182](#1182)) - chore(deps): update dependencies (patch) (#1185) ([#1185](#1185)) ### Csskit_derives - csskit_derives: Ensure generics expect Peek when using it. (#1198) ([#1198](#1198)) ### Csskit_source_finder - csskit_source_finder: Don't find visitable nodes that just visit children (#1199) ([#1199](#1199)) ### Csskit_vscode - chore(deps): update dependency @vscode/test-electron to v3 (#1192) ([#1192](#1192)) - fix(deps): update dependency esbuild to v0.28.1 [security] (#1210) ([#1210](#1210))
keithamus
added a commit
that referenced
this pull request
Jun 13, 2026
## [0.0.25] - 2026-06-13 ### Other Changes - Update cargo deps (#1189) ([#1189](#1189)) - Push allocator-api2 back to 2.21 due to bumpalo (#1191) ([#1191](#1191)) - Fuzz: Try setting up a fuzzing suite (#1201) ([#1201](#1201)) ### Css_ast - css_ast: Avoid hanging on `={-->}` input. (#1183) ([#1183](#1183)) - Regenerate css_ast/src/values from csswg drafts (#1184) ([#1184](#1184)) - css_ast: Use assert_parse! closure macro variant in tests. (#1196) ([#1196](#1196)) - cssast/csskit_derives: Add new FeatureMetadata system (#1197) ([#1197](#1197)) - csskit_derives/css_ast: make derive(IntoCursor) work with generics (#1200) ([#1200](#1200)) - css_ast: Implement a NonEmpty generic (#1202) ([#1202](#1202)) ### Css_lexer - fuzz: early return atom functions when given non-atom tokens (#1206) ([#1206](#1206)) - fuzz(css_lexer): ensure REPLACEMENT_CHARACTER is appended in small idents (#1213) ([#1213](#1213)) ### Css_parse - css_parse: Ensure buffer is refilled if skipping past a whole buffer (#1180) ([#1180](#1180)) - css_parse: Impl ToSpan for Comparison (#1190) ([#1190](#1190)) - Impl Display for Comparison (#1193) ([#1193](#1193)) - css_parse: Improve assert_parse! macros to use a block/closure (#1194) ([#1194](#1194)) ### Csskit - csskit: improve json output for subcommands (#1182) ([#1182](#1182)) - chore(deps): update dependencies (patch) (#1185) ([#1185](#1185)) ### Csskit_derives - csskit_derives: Ensure generics expect Peek when using it. (#1198) ([#1198](#1198)) ### Csskit_source_finder - csskit_source_finder: Don't find visitable nodes that just visit children (#1199) ([#1199](#1199)) ### Csskit_vscode - chore(deps): update dependency @vscode/test-electron to v3 (#1192) ([#1192](#1192)) - fix(deps): update dependency esbuild to v0.28.1 [security] (#1210) ([#1210](#1210))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently csskit_source_finder's find_visitable_nodes function returns all nodes
which derive(Visitable). This includes those that
visit(children), despitethose nodes never needing to emit a
visit_<ty>method, as they never call it.This change ensures those types are skipped, so css_ast doesn't emit those visit
methods, as they're never called!