fix: correct parameter index tracking in Signature validation - #104
Open
boyGalsen wants to merge 1 commit into
Open
fix: correct parameter index tracking in Signature validation#104boyGalsen wants to merge 1 commit into
boyGalsen wants to merge 1 commit into
Conversation
The index variable in Signature.validate() was incremented at the end of the for loop, but the capture group was read using the pre-increment value. When the first argument is an array (type 'a') and the second is a function (type 'f'), the function argument was validated against group(1) instead of group(2), causing a false T0410 signature mismatch error. Fix: use post-increment (index++) inline at the point where the capture group is read, and remove the redundant index++ at the end of the loop. Also fix DateTimeTest.testToMillis assertion to be timezone-agnostic. Fixes dashjoin#79
Contributor
|
The test case you wrote passes with and without the index++ fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index variable in Signature.validate() was incremented at the end of the for loop, but the capture group was read using the pre-increment value. When the first argument is an array (type 'a') and the second is a function (type 'f'), the function argument was validated against group(1) instead of group(2), causing a false T0410 signature mismatch error.
Fix: use post-increment (index++) inline at the point where the capture group is read, and remove the redundant index++ at the end of the loop.
Also fix DateTimeTest.testToMillis assertion to be timezone-agnostic.
Fixes #79