Fix +: being erroneously interpreted as :#155
Merged
lihaoyi-databricks merged 2 commits intodatabricks:masterfrom May 30, 2023
nicholashusin:master
Merged
Fix +: being erroneously interpreted as :#155lihaoyi-databricks merged 2 commits intodatabricks:masterfrom nicholashusin:master
lihaoyi-databricks merged 2 commits intodatabricks:masterfrom
nicholashusin:master
Conversation
When using +: within an object comprehension, sjsonnet will interpret it as a : instead. This creates an inconsistency with the official implementation of jsonnet. This commit fixes said issue by making sure that + are correctly parsed and evaluated within object comprehension.
|
LGTM |
This was referenced May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #154.
When using +: within an object comprehension, sjsonnet will interpret it as a : instead. This creates an inconsistency with the official implementation of jsonnet. This commit fixes said issue by making sure that + are correctly parsed and evaluated within object comprehension.