Skip to content

Add a few more methods to sjsonnet, like std.sha*, std.trim, std.isEmpty#210

Merged
stephenamar-db merged 1 commit intomasterfrom
newmethods
Nov 5, 2024
Merged

Add a few more methods to sjsonnet, like std.sha*, std.trim, std.isEmpty#210
stephenamar-db merged 1 commit intomasterfrom
newmethods

Conversation

@stephenamar-db
Copy link
Copy Markdown
Collaborator

@stephenamar-db stephenamar-db commented Nov 2, 2024 •
edited
Loading

This PR adds a bunch of missing methods to sjsonnet.

  • isEmpty
  • xor
  • xnor
  • trim
  • equalsIgnoreCase
  • sha1
  • sha256
  • sha512
  • sha3
@stephenamar-db stephenamar-db marked this pull request as ready for review November 2, 2024 05:14
@stephenamar-db stephenamar-db force-pushed the newmethods branch 5 times, most recently from 7de8e3f to 51ce58f Compare November 3, 2024 03:56
jordanmoxon-db
jordanmoxon-db approved these changes Nov 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jordanmoxon-db jordanmoxon-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Thanks for adding these!
@stephenamar-db stephenamar-db merged commit 6939b1a into master Nov 5, 2024
@stephenamar-db stephenamar-db deleted the newmethods branch November 5, 2024 17:56
@stephenamar-db stephenamar-db mentioned this pull request Dec 2, 2024
Merged
stephenamar-db added a commit that referenced this pull request Dec 2, 2024
@stephenamar-db
Fix a bug leading to the truncation of the data returned by std.gzip …
2047a32 
…and std.xz (#221)

The output of std.gzip and std.xz was truncated because the output
stream was closed after being read and encoded into base64.

This regression was introduced in
#210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@stephenamar-db @jordanmoxon-db