Non-Boolean Conditions fix#44
Merged
lihaoyi merged 3 commits intodatabricks:masterfrom Oct 28, 2019
modusintegration:NonBooleanExpressionsFix
Merged
Non-Boolean Conditions fix#44lihaoyi merged 3 commits intodatabricks:masterfrom modusintegration:NonBooleanExpressionsFix
lihaoyi merged 3 commits intodatabricks:masterfrom
modusintegration:NonBooleanExpressionsFix
Conversation
added 2 commits
October 21, 2019 12:32
An expression like [x for x in [1,2,3] if 'a'] in Jsonnet results in error "Condition must be boolean, got string" - but sjsonnet does not fail. This PR fixes it.
Contributor
|
@javaduke can you submit the PR without all the unrelated reformatings? |
Contributor
Author
|
Ah, sorry, will do. Apparently IntelliJ does all this automatically, I didn't even realize the formatting is different. Sorry about it. |
Contributor
|
Looks good, thanks! |
stephenamar-db
pushed a commit
that referenced
this pull request
Dec 4, 2025
…lts instead of treating them as "false" (#559) This PR fixes a bug where `filter()` and `filterMap()` mishandled filter predicate results that weren't booleans: instead of failing with an error, jsonnet treated any non-boolean value as though it was false. For example: ```jsonnet std.filter(function(x) "not a boolean", [1, 2, 3]) // sjsonnet (before): [] (silently treats non-boolean as false) // jsonnet: RUNTIME ERROR: filter function must return boolean, got: string // go-jsonnet: RUNTIME ERROR: Unexpected type string, expected boolean ``` The problem was that evaluator code was checking `.isInstanceOf[Val.True]` rather than explicitly checking for booleans (very similar to the past issue fixed in #44). This PR's fix is to update this logic to use `.asBoolean` , which throws an explicit type error for non-booleans: ``` sjsonnet.Error: Wrong parameter type: expected Boolean, got string ``` --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An expression like [x for x in [1,2,3] if 'a'] in Jsonnet results in error "Condition must be boolean, got string" - but sjsonnet does not fail. This PR fixes it.