Re-enable handling of unicode strings in std.base64#492
Merged
stephenamar-db merged 1 commit intomasterfrom Aug 29, 2025
Merged
Re-enable handling of unicode strings in std.base64#492stephenamar-db merged 1 commit intomasterfrom
stephenamar-db merged 1 commit intomasterfrom
Conversation
stephenamar-db
force-pushed
the
stephenamar-db/b64fix
branch
from
e43b20c to
4686dec
Compare
stephenamar-db
added a commit
that referenced
this pull request
Aug 29, 2025
This is an artificial limitation in go-jsonnet and we are not bound by it. We are perfectly capable of encoding and decoding unicode strings.
stephenamar-db
added a commit
that referenced
this pull request
Aug 29, 2025
He-Pin
reviewed
Aug 29, 2025
| Base64.getEncoder.encodeToString(value.getBytes("UTF-8")) | ||
| case arr: Val.Arr => | ||
| val byteArr = new Array[Byte](arr.length) | ||
| for (i <- 0 until arr.length) { |
Collaborator
Author
There was a problem hiding this comment.
I want the index though, for better error message.
Why would a while loop work better?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an artificial limitation in go-jsonnet and we are not bound by it.
We are perfectly capable of encoding and decoding unicode strings.