chore: Update tests in UnicodeHandling #507
Merged
stephenamar-db merged 1 commit intodatabricks:masterfrom Sep 23, 2025
Merged
Conversation
JoshRosen
reviewed
Sep 20, 2025
JoshRosen
reviewed
Sep 20, 2025
He-Pin
commented
Sep 21, 2025
| // sjsonnet was parses these successfully (go/C++ would reject) | ||
| // the new behavior will reject thesee too | ||
| evalErr("\"\\uD800\"").contains("Expected") // High surrogate alone | ||
| evalErr("\"\\uDC00\"").contains("Expected") // Low surrogate alone |
Contributor
Author
There was a problem hiding this comment.
@JoshRosen the new behavior will fail now
Contributor
Author
There was a problem hiding this comment.
Error: example1.jsonnet:1:1-9 example1.jsonnet:1:1-9 Truncated unicode surrogate pair escape sequence in string literal.
"\uD800"
in jsonnet.org
Contributor
Author
|
@stephenamar-db I think this should be merged to get other PR's tests green. |
stephenamar-db
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
refs: #508
@JoshRosen said, in both go/cpp jsonnet has behavior :
But in my recent PR, which actually will reject the wrong Unicode.
@JoshRosen @stephenamar-db Should we do this before 1.0.0? I think so, because the wrong Unicode will cause unexpected behavior anyway.