chore: Avoid left-shift of negative values port google/jsonnet#1288#612
Merged
stephenamar-db merged 1 commit intodatabricks:masterfrom Feb 27, 2026
Merged
chore: Avoid left-shift of negative values port google/jsonnet#1288#612stephenamar-db merged 1 commit intodatabricks:masterfrom
stephenamar-db merged 1 commit intodatabricks:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ports a fix from google/jsonnet#1288 that prevents undefined behavior when left-shifting negative values. The fix ensures that overflow detection for bitwise left-shift operations works correctly for both positive and negative operands by using the absolute value in the comparison.
Changes:
- Updated overflow check in left-shift operation to use
math.abs(ll)instead ofllwhen validating if the shift would exceed safe integer range
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stephenamar-db
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid left-shift of negative values port