Skip to content

Add array and object comprehensions to stack trace frames#638

Merged
stephenamar-db merged 1 commit intomasterfrom
comp-stack-trace
Mar 6, 2026
Merged

Add array and object comprehensions to stack trace frames#638
stephenamar-db merged 1 commit intomasterfrom
comp-stack-trace

Conversation

@stephenamar-db
Copy link
Copy Markdown
Collaborator

@stephenamar-db stephenamar-db commented Mar 5, 2026

Summary

  • Array comprehensions (Comp) and object comprehensions (ObjBody.ObjComp) now appear in stack traces as [array comprehension] and [object comprehension], giving better context when errors originate inside comprehension bodies.
  • Adds exprErrorString overrides and includes both types in the isApplyOrBuiltin frame filter.

Test plan

  • JVM tests pass (140/140)
  • 12 golden files updated with new comprehension frames
  • 3 EvaluatorTests assertions updated
@stephenamar-db
Add array and object comprehensions to stack trace frames
bf1d659 
Comprehension expressions (Comp, ObjBody.ObjComp) now appear in stack
traces as [array comprehension] and [object comprehension], giving
better context when errors originate inside comprehension bodies.
@stephenamar-db stephenamar-db marked this pull request as draft March 5, 2026 22:58
@stephenamar-db stephenamar-db marked this pull request as ready for review March 5, 2026 22:58
@stephenamar-db stephenamar-db merged commit 8cb7cfe into master Mar 6, 2026
15 of 16 checks passed
@stephenamar-db stephenamar-db deleted the comp-stack-trace branch March 6, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@stephenamar-db