Merged
Conversation
This makes adjacent object literals an error. Fixes databricks#87
lihaoyi-databricks
approved these changes
Aug 25, 2020
Contributor
lihaoyi-databricks
left a comment
lihaoyi-databricks
left a comment
There was a problem hiding this comment.
lgtm feel free to merge when ready
Contributor
|
I wonder if this isn't too strict, perhaps we should disallow it only inside lists? Wondering how well this would fare on our existing body of jsonnet. :) |
Contributor
|
@iuliand-db I'd say this is probably OK, as we have the flexibility to adjust our existing body of Jsonnet accordingly. The golden ZZZ files should make it pretty easy to notice all the places where we need to tweak, and it should be easy to add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes adjacent object literals an error. Fixes #87