Skip to content

Read project_id from credentials (rebase of #143) - #151

Open
sabman wants to merge 1 commit into
masterfrom
fix/pr-143-rebase
Open

sabman wants to merge 1 commit into
masterfrom
fix/pr-143-rebase

Conversation

@sabman

@sabman sabman commented Aug 18, 2026

Copy link
Copy Markdown
Member

Summary

Original PR: #143 by @xavarius

Test plan

  • Specs pass
  • FCM.new(credentials_path) works without project id
  • Explicit project name still works (with deprecation warning)
  • timeout / keep_alive_connections still work as kwargs after credentials
Based on #143 by @xavarius. Squashed and rebased onto current master,
preserving keep-alive / http_options behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant