Skip to content

fix(repl): panic when user delete globalThis.globalThis #28960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(repl): panic when user delete globalThis.globalThis #28960

wants to merge 1 commit into from

Conversation

CyanChanges
Copy link
Contributor

@CyanChanges CyanChanges commented Apr 18, 2025 •
edited
Loading

Closes #28959

Before the pr

image

With the pr

image
At least it didn't panic
@CyanChanges CyanChanges force-pushed the fix-delete-globalthis-panic branch 3 times, most recently from 0bbf70d to 96dbc9e Compare April 18, 2025 16:21
@CyanChanges CyanChanges force-pushed the fix-delete-globalthis-panic branch from 96dbc9e to ad49c17 Compare April 19, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@CyanChanges