Conversation
DIGRAPHS_NautyAvailable and NAUTY_DATA were fixed when Digraphs was loaded, depending on whether NautyTracesInterface was marked for loading at that point. Loading NautyTracesInterface afterwards left nauty unusable, e.g. NautyAutomorphismGroup returned fail. Start with nauty unavailable and let a package extension, which GAP reads as soon as both packages are loaded, install NAUTY_DATA and set DIGRAPHS_NautyAvailable. Extensions require GAP 4.13, so drop GAP 4.11 and 4.12 from CI. Assisted-by: Claude Code (Opus 5.5)
Without GRAPE, Digraphs bound IsGraph, Vertices and Adjacency itself to avoid warnings about unbound globals. Loading GRAPE afterwards then printed warnings such as "BIND_GLOBAL: variable `Adjacency' already has a value". Look the GRAPE functions up at runtime instead. Assisted-by: Claude Code (Opus 5.5)
Assisted-by: Claude Code (Opus 5.5)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
==========================================
+ Coverage 97.45% 97.47% +0.02%
==========================================
Files 50 51 +1
Lines 21189 21187 -2
Branches 639 639
==========================================
+ Hits 20649 20652 +3
+ Misses 475 470 -5
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 of 19 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now the nauty support (
DIGRAPHS_NautyAvailable,NAUTY_DATA) was read only if NautyTracesInterface was already marked for loading when Digraphs got loaded. Whether the feature is available therefore depended on load order:LoadPackage("Digraphs"); LoadPackage("NautyTracesInterface");silently left it out, and the only remedy was restarting GAP and loading the packages the other way round.This PR declares that code in the
Extensionscomponent ofPackageInfo.ginstead (see gap-system/gap#5760 and the section "Extensions Provided by a Package" in the GAP reference manual). GAP reads an extension as soon as all packages it needs are loaded, in whichever order that happens.Extensions require GAP 4.13 (released 2024), so this raises the minimal GAP version to 4.13; GAP 4.11 and 4.12 are dropped from CI.
Tested: loading Digraphs with
OnlyNeededand then NautyTracesInterface (and GRAPE), and the reverse order, both provide the feature;tst/teststandard.gpasses with and without suggested packages.Before, loading NautyTracesInterface after Digraphs left nauty unusable, e.g.
NautyAutomorphismGroupreturnedfail.There are two further commits:
IsGraph,VerticesandAdjacencyitself, so loading GRAPE afterwards printed warnings such asBIND_GLOBAL: variable `Adjacency' already has a value. These functions are now looked up at runtime.UserHomeExpandfallbacks, theIsKernelExtensionAvailableworkaround inPackageInfo.g, and aCompareVersionNumbersbranch inoper.gi.🤖 Generated with Claude Code