Skip to content

Fix avatar sync for a SSO#49

Merged
webrender merged 1 commit intodisqus:masterfrom
klaufel:fix-avatar
May 24, 2018
Merged

Fix avatar sync for a SSO#49
webrender merged 1 commit intodisqus:masterfrom
klaufel:fix-avatar

Conversation

@klaufel
Copy link
Copy Markdown
Contributor

@klaufel klaufel commented May 15, 2018

Working on the web "http://nintenderos.com" we were having an avatars synchronization problem. Reading the official documentation of Disqus I observed that the value of the parameter that is required in the configuration "avatar" is a url and the function that currently exists get_avatar() returns <img src="..."> when it should return a string with a url.

Image with Disqus documentation:
image

I have modified the function by get_avatar_url() so that it always returns the url of the avatar, so when the avatar value is updated it will show the new avatar.

@webrender
Copy link
Copy Markdown
Contributor

Thanks for this PR! We're going to run some tests against it and hopefully release an update which includes it tomorrow.

@webrender webrender merged commit d2926d5 into disqus:master May 24, 2018
@dmatt
Copy link
Copy Markdown
Contributor

dmatt commented May 25, 2018

@klaufel We finished testing and your PR made it into the recent 3.0.16 release, https://wordpress.org/plugins/disqus-comment-system/#developers. Thank you!

@psbaj
Copy link
Copy Markdown

psbaj commented May 28, 2018

Thank you so much for this fix! I contacted disqus support last year about this issue and they told me that the problem was my server ¬¬ well, not a problem anymore :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants