Closed
Conversation
Contributor
Author
Closed
AkihiroSuda
force-pushed
the
rootless
branch
2 times, most recently
from
d71b5c3 to
a4ed75c
Compare
Contributor
|
a quick test. |
Contributor
Author
|
What's your host kernel? |
Contributor
|
Contributor
|
You are right! 👍 It can solve this error. I have another error |
Contributor
|
systemd cgls info |
tao12345666333
approved these changes
Jul 11, 2019
Contributor
tao12345666333
left a comment
tao12345666333
left a comment
There was a problem hiding this comment.
In short, I think there is a problem with my environment, I will continue to debug and solve it.
For this change, LGTM
Thanks 👍
Contributor
Author
|
cgroup error is weird. does |
Usage: $ docker build -t dind-rootless . $ docker run -d --name dind-rootless --privileged dind-rootless $ docker exec dind-rootless docker info * The daemon runs in an unprivileged user with ID 1000 * `--privileged` is still required due to seccomp, apparmor, procfs, and sysfs stuff * `-H tcp://....` will be supported soon: moby/moby#39493 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Contributor
Author
|
updated pr to add entrypoint script for automatically fallback to vfs storage driver |
Contributor
Yes, the full outputs here. |
Contributor
I will give it a try ASAP. （on holiday. |
Contributor
|
Using latest update to build image and run it. I get the same error. Here is the container's log. |
Contributor
Author
|
Is the failure specific to dind? |
Contributor
|
It specific to dind-rootless. docker:dind works fine. |
Contributor
Author
|
Does non-dind rootless work? |
Contributor
Yes. It works well. Its |
Contributor
Author
|
I confirmed that the issue can be avoided by applying the following patch to containerd daemon, but not sure why it is specific to Fedora. Couldn't reproduce on Ubuntu. diff --git a/runtime/v1/linux/task.go b/runtime/v1/linux/task.go
index e13255e9..80eb0d64 100644
--- a/runtime/v1/linux/task.go
+++ b/runtime/v1/linux/task.go
@@ -124,7 +124,7 @@ func (t *Task) Start(ctx context.Context) error {
t.pid = int(r.Pid)
if !hasCgroup {
cg, err := cgroups.Load(cgroups.V1, cgroups.PidPath(t.pid))
- if err != nil {
+ if err != nil && err != cgroups.ErrCgroupDeleted {
return err
}
t.mu.Lock(EDIT: On Ubuntu, as EDIT: PR containerd/containerd#3419 |
Contributor
|
Thanks. Let me have a try. |
AkihiroSuda
added a commit
to AkihiroSuda/containerd
that referenced
this pull request
Jul 17, 2019
Fix a Rootless Docker-in-Docker issue on Fedora 30: docker-library/docker#165 (comment) Related: containerd#1598 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/containerd
that referenced
this pull request
Jul 18, 2019
Fix a Rootless Docker-in-Docker issue on Fedora 30: docker-library/docker#165 (comment) Related: containerd#1598 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit fab016c) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Contributor
Author
|
closing in favor of #174 |
tussennet
pushed a commit
to tussennet/containerd
that referenced
this pull request
Sep 11, 2020
Fix a Rootless Docker-in-Docker issue on Fedora 30: docker-library/docker#165 (comment) Related: containerd#1598 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage:
--privilegedis still required due to seccomp, apparmor, procfs, and sysfs stuff-H tcp://....will be supported soon: rootless: allow exposing dockerd TCP socket easily moby/moby#39493Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp