Add additionalProperties for JsonExtensionData schemas#67456
Open
mete0rfish wants to merge 4 commits into
Open
Add additionalProperties for JsonExtensionData schemas#67456mete0rfish wants to merge 4 commits into
mete0rfish wants to merge 4 commits into
Conversation
Contributor
|
Thanks for your PR, @mete0rfish. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
@dotnet-policy-service agree |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additionalProperties for JsonExtensionData schemas
Added support for
JsonExtensionDatain OpenAPI schema generation by setting additionalProperties for object schemas that accept extension data.Description
OpenAPI schema generation was not reflecting
JsonExtensionDataproperties, so DTOs that can deserialize undeclared JSON properties were still emitted as schemas without free-form additional properties.This changes the schema generation logic to detect
JsonTypeInfoobject types with extension data and add an emptyadditionalPropertiesschema when one has not already been set. This preserves any existing additionalProperties value while making the generated schema match the runtime JSON behavior.Fixes #66338