This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Initial IsolatedStorage implementation#11080
Merged
JeremyKuhne merged 2 commits intodotnet:dev/apifrom Aug 26, 2016
Merged
Conversation
| @@ -0,0 +1,3 @@ | |||
| Compat issues with assembly System.IO.IsolatedStorage: | |||
| CannotAddAbstractMembers : Member 'System.IO.IsolatedStorage.IsolatedStorage.GetPermission(System.Security.PermissionSet)' is abstract in the implementation but is missing in the contract. | |||
| Total Issues: 1 | |||
Member
Author
There was a problem hiding this comment.
Whoops. I'll clear the duplicate file.
Member
|
|
| internal static void CreateDirectory(string path, IsolatedStorageScope scope) | ||
| { | ||
| // ACL'ing isn't an issue in WinRT, just create it | ||
| Directory.CreateDirectory(path); |
Member
There was a problem hiding this comment.
We can just use Directory.CreateDirectory at the call site then. No need for the scope. Etc.
Member
Author
There was a problem hiding this comment.
Other than I'm calling this helper in shared code. I figured it was better to call the helper here than not since it is there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements most of the APIs we intend to provide. Still pending are:
We do not plan to implement the store iterator or any factory methods that take arguments yet.
Tests are forthcoming- the helper class is intended to facilitate unit testing as well as abstracting platform differences. Also need to fix packages and UWP build.
This PR is NOT going in as is- this is to facilitate design feedback as I add tests and fix the packaging/UWP issues.
@ellismg; @weshaggard; @ericstj; @danmosemsft