Disable odbc tests on net9 interpreter - #117245
Merged
BrzVlad merged 1 commit intoJul 8, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables a set of ODBC integration tests on the Mono interpreter (net9) by marking them with an ActiveIssue attribute.
- Adds
[ActiveIssue(..., PlatformDetection.IsMonoInterpreter)]to individual test methods. - Targets tests across multiple files to skip them until issue #116482 is addressed.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Data.Odbc/tests/SmokeTest.cs | Marked CreateInsertSelectTest with ActiveIssue |
| src/libraries/System.Data.Odbc/tests/ReaderTests.cs | Added ActiveIssue to several reader-related test methods |
| src/libraries/System.Data.Odbc/tests/DependencyCheckTest.cs | Marked dependency-check test with ActiveIssue |
| src/libraries/System.Data.Odbc/tests/ConnectionTests.cs | Added ActiveIssue to connection test |
| src/libraries/System.Data.Odbc/tests/CommandBuilderTests.cs | Marked command-builder tests with ActiveIssue |
Member
Author
|
@ericstj @akoeplinger This is just for green CI on .net9. What would be the process with this ? Does it need to go through normal tactics approval like normal fixes ? |
akoeplinger
approved these changes
Jul 2, 2025
Member
|
Test-only changes are tell-mode. |
Member
|
@BrzVlad you're free to merge this. |
This was referenced Aug 5, 2025
Bump Microsoft.Extensions.DependencyInjection.Abstractions and System.Text.Json
tryAGI/LangChain#562
Closed
This was referenced Aug 7, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#116482