[QUIC] Disable Quic tests on AzL3 VM#125665
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
steveisok
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Disables System.Net.Quic functional tests on Azure Linux 3 (non-container) environments to avoid known MsQuic failures (QUIC_STATUS_OUT_OF_MEMORY) tracked in #123216.
Changes:
- Added a new
QuicTestBasecondition to skip tests on Azure Linux (unless running in a container). - Applied the new condition to multiple QUIC functional test classes via
ConditionalClass.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs | Adds IsNotAzureLinux3VM condition used to gate QUIC functional tests. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs | Adds the new Azure Linux gating condition to the class. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamConnectedStreamConformanceTests.cs | Adds the new Azure Linux gating condition to the class. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs | Adds the new Azure Linux gating condition to the class. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs | Adds the new Azure Linux gating condition to the class. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs | Adds the new Azure Linux gating condition to the class. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicRemoteExecutorTests.cs | Adds the new Azure Linux gating condition to the class. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicCipherSuitesPolicyTests.cs | Adds the new Azure Linux gating condition to the class. |
This was referenced Mar 17, 2026
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
4 tasks
akoeplinger
pushed a commit
that referenced
this pull request
Mar 24, 2026
Backport of #125665 to release/10.0 ## Customer Impact - [ ] Customer reported - [ ] Found internally [Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.] ## Regression - [ ] Yes - [ ] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. --------- Co-authored-by: ManickaP <mapichov@microsoft.com> Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
rzikm
added a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Apr 7, 2026
HTTP/3 tests on azurelinux.3.amd64.open.rt consistently fail because the underlying MsQuic library fails with QUIC_STATUS_OUT_OF_MEMORY on that queue. The QUIC tests were already disabled for the same reason in PRs dotnet#125665 and dotnet#125772 using the IsNotAzureLinux3VM condition. Apply the same condition to IsHttp3Supported so all HTTP/3 test classes are also skipped on AzureLinux 3 VMs. Relates to dotnet#123216 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzikm
added a commit
that referenced
this pull request
Apr 8, 2026
HTTP/3 tests (`TelemetryTest_Http30`, and potentially other `*_Http3` / `*_Http30` classes) consistently fail on `azurelinux.3.amd64.open.rt` because the underlying MsQuic library fails with `QUIC_STATUS_OUT_OF_MEMORY` on that queue. The QUIC tests were already disabled for the same reason in PRs #125665 and #125772 using the `IsNotAzureLinux3VM` condition on `[ConditionalClass]`. However, the HTTP/3 test classes use `IsHttp3Supported` from `HttpClientHandlerTestBase` as their gate, so they were not covered by the QUIC-side fix. This PR adds the same `IsNotAzureLinux3VM` check to `IsHttp3Supported`, which will skip all HTTP/3 test classes on AzureLinux 3 VMs where QUIC is broken. Relates to #123216 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Apr 9, 2026
HTTP/3 tests (`TelemetryTest_Http30`, and potentially other `*_Http3` / `*_Http30` classes) consistently fail on `azurelinux.3.amd64.open.rt` because the underlying MsQuic library fails with `QUIC_STATUS_OUT_OF_MEMORY` on that queue. The QUIC tests were already disabled for the same reason in PRs dotnet#125665 and dotnet#125772 using the `IsNotAzureLinux3VM` condition on `[ConditionalClass]`. However, the HTTP/3 test classes use `IsHttp3Supported` from `HttpClientHandlerTestBase` as their gate, so they were not covered by the QUIC-side fix. This PR adds the same `IsNotAzureLinux3VM` check to `IsHttp3Supported`, which will skip all HTTP/3 test classes on AzureLinux 3 VMs where QUIC is broken. Relates to dotnet#123216 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #123216