Skip to content

Support composer 2 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

brambaud
Copy link
Contributor

Issue links

#21

Description

See https://getcomposer.org/upgrade/UPGRADE-2.0.md

The only things that interest us if I read correctly is:

PluginInterface added a deactivate (so plugin can stop whatever it is doing) and an uninstall (so the plugin can remove any files it created or do general cleanup) method.

I chose to do nothing during those new phases. Maybe we could delete the created web-dir? 🤷‍♂️

@brambaud
Copy link
Contributor Author

brambaud commented Oct 26, 2020

Jobs where already stuck in 1.x https://travis-ci.org/github/drupal-composer/drupal-paranoia/builds/739078328 🤔

Jobs are just really slow to start 😅

@brambaud brambaud force-pushed the issue/21/support-composer-2 branch from a2c262f to 926b0b6 Compare October 26, 2020 20:26
@brambaud brambaud marked this pull request as draft October 26, 2020 22:06
@FlorentTorregrosa
Copy link

Hello,

Thanks for the PR

@brambaud brambaud force-pushed the issue/21/support-composer-2 branch from 1638bbc to cb0e0ac Compare November 1, 2020 20:21
@brambaud brambaud marked this pull request as ready for review November 1, 2020 20:22
@brambaud brambaud force-pushed the issue/21/support-composer-2 branch from cb0e0ac to 31fa18d Compare November 1, 2020 20:40
@brambaud brambaud force-pushed the issue/21/support-composer-2 branch from 31fa18d to 0bc0eb6 Compare November 1, 2020 20:50
@brambaud
Copy link
Contributor Author

brambaud commented Nov 1, 2020

@FlorentTorregrosa Thanks for the test! Glad it works elsewhere than on my projects ^^

@jkribeiro CI has been updated to:

  • test with Drupal 9: drupal-composer/drupal-project:8.x-dev contains some dependencies that don't support composer 2 like drupal/console.
  • test using composer 2 and composer 1
  • only keep PHP >= 7.3: PHP 7.2 security support ends at the end of the month, Drupal 9 does not officially support it and it is consistent with https://github.com/drupal-composer/drupal-project
@brambaud
Copy link
Contributor Author

@emilorol Could you explain why did you post those links please? 😃

@brambaud brambaud closed this Nov 17, 2020
@brambaud brambaud reopened this Nov 17, 2020
@brambaud
Copy link
Contributor Author

(sorry for the inconvenience.. just a miss click.. 😿 )

@jkribeiro
Copy link
Collaborator

Thanks guys, this is a very good start.

Regarding the new methods, I think it is fine to leave as is for now, we don't want to mess with site's web-dir if the plugin is removed. We can iterate on it later if necessary.

I'll cut a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants