-
Notifications
You must be signed in to change notification settings - Fork 7
Support composer 2 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support composer 2 #22
Conversation
Jobs are just really slow to start 😅 |
a2c262f
to
926b0b6
Compare
Hello, Thanks for the PR |
Tested on my Drupal project template https://gitlab.com/florenttorregrosa-drupal/docker-drupal-project/-/commit/5c30b3b3e968dd25ad0c864ef4bc5cbedfdee6c5 and it is OK. Thanks! |
1638bbc
to
cb0e0ac
Compare
cb0e0ac
to
31fa18d
Compare
31fa18d
to
0bc0eb6
Compare
@FlorentTorregrosa Thanks for the test! Glad it works elsewhere than on my projects ^^ @jkribeiro CI has been updated to:
|
@emilorol Could you explain why did you post those links please? 😃 |
(sorry for the inconvenience.. just a miss click.. 😿 ) |
Thanks guys, this is a very good start. Regarding the new methods, I think it is fine to leave as is for now, we don't want to mess with site's web-dir if the plugin is removed. We can iterate on it later if necessary. I'll cut a new release. |
Issue links
#21
Description
See https://getcomposer.org/upgrade/UPGRADE-2.0.md
The only things that interest us if I read correctly is:
I chose to do nothing during those new phases. Maybe we could delete the created
web-dir
? 🤷♂️