Skip to content

Refactoring - Rewrite - #19

Draft
drupol wants to merge 2 commits into
masterfrom
push-spymmsvvlvmu
Draft

Refactoring - Rewrite#19
drupol wants to merge 2 commits into
masterfrom
push-spymmsvvlvmu

Conversation

@drupol

@drupol drupol commented Jan 2, 2025

Copy link
Copy Markdown
Owner

This PR

  • [x]
  • [ ]
  • [ ]

Follows #.
Related to #.
Fixes #.
@drupol
drupol force-pushed the push-spymmsvvlvmu branch 3 times, most recently from 47f4b8f to 779bee1 Compare January 2, 2025 13:37
@drupol
refact: rewrite of the library
f5968c4 
- Remove Generators - It was not necessary to keep them
- Switch to PHPUnit 11
- Remove temporarily drupol/php-conventions, deps issue with vimeo/psalm
- Remove methods toArray and count
- Remove custom interfaces
- Update CI
@drupol
drupol force-pushed the push-spymmsvvlvmu branch from 779bee1 to f5968c4 Compare January 2, 2025 13:39
@thepercival

thepercival commented Nov 19, 2025

Copy link
Copy Markdown

Hello,

Need any help? Is the rework still in progress? Last commit is from 2 jan.
@drupol

drupol commented Nov 19, 2025

Copy link
Copy Markdown
Owner Author

Hello,

Sadly I don't have the time to take care of this project at the moment... do you feel like helping?
@thepercival

thepercival commented Nov 19, 2025 via email

Copy link
Copy Markdown
@drupol

drupol commented Nov 19, 2025

Copy link
Copy Markdown
Owner Author

I don't really have anything to elaborate here, I don't have time to continue on this at the moment, and if you feel like taking over, feel free to open a PR, I'll be glad to review it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@drupol @thepercival