Use optional types for missing fields#8
Closed
kalouantonis wants to merge 1 commit into
Closed
Conversation
kalouantonis
force-pushed
the
feature/option
branch
2 times, most recently
from
e4f8347 to
8832677
Compare
Instead of returning an empty string, None is returned instead.
kalouantonis
force-pushed
the
feature/option
branch
from
8832677 to
5e075a0
Compare
Collaborator
|
Thanks! There are now tests, so I modified the tests to conform and merged as 1e7f279. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of returning an empty string, None is returned instead.
This is more inline with what is considered idiomatic rust.