default functions should be optional#302
Open
patrickomeara wants to merge 3 commits intoecrmnn:masterfrom
Open
default functions should be optional#302patrickomeara wants to merge 3 commits intoecrmnn:masterfrom
patrickomeara wants to merge 3 commits intoecrmnn:masterfrom
Conversation
* use condition passed in * return unknown from closures and methods
Owner
|
Hi, @patrickomeara Thanks for your feedback and contribution 😄 I appreciate your work on types and would encourage you to make more contributions on this 🙌 It would be great to transition towards TS, but personally I don't have the time and therefore no intention to rewrite the package to TS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main thing I wanted out of this PR was making the default functions optional. I then started correcting the logic based on Laravel's logic and adding types.
I've used
unkownhere as we don't know what is going to be returned. I've also copied laravelunlessmethod. It andwhentake the value as the second argument in the closures, so we effectively don't know what will be returned.After looking through the code and working on a few PRs I think this package needs to be rewritten in TS. I'm happy to help out as I use this package quite a bit. Writing in typescript will remove disconnect between the javascript and the type definitions.
Let's discuss what's possible @ecrmnn