ESQL: Don't push down filters on the right hand side of an inlinejoin #127383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @astefan, I've created a changelog YAML for you. |
inlinestats capability)
…ps://github.com/astefan/elasticsearch into skip_filters_pushdown_on_inlinestats_right_side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing down filters on the left hand side of an inlinestats commands could apparently be beneficial, but the source of the right hand side of the said inlinestats is the same as the left hand side one and this will inherently use the same filters, which is wrong.
For ex,
FROM employees | INLINESTATS max_salary = MAX(salary) by languages | KEEP emp_no, languages, max_salary | WHERE emp_no == 10003would consideremp_no == 10003as eligible to be used likeWHERE emp_no == 10003 | STATS MAX(salary) by languageswhich changes drastically the outcome of thestatscommand.