feat: add getBackgroundThrottling() + backgroundThrottling property#21036
Merged
Conversation
Contributor
Author
|
@codebytere should the property also be documented in |
codebytere
requested changes
May 5, 2020
Member
There was a problem hiding this comment.
@miniak we made a decision on the propertyification a while back - we will be supporting both approaches (meaning that we will add support for ES6 get/set while also keeping previous getX()/setX(newX) functionality. If you can update this accordingly we can move it forward.
miniak
force-pushed
the
miniak/background-throttling-property
branch
from
11c38df to
339d3f8
Compare
miniak
changed the title
miniak
force-pushed
the
miniak/background-throttling-property
branch
from
339d3f8 to
762aa31
Compare
miniak
changed the title
miniak
force-pushed
the
miniak/background-throttling-property
branch
from
762aa31 to
1d1eebf
Compare
codebytere
approved these changes
May 13, 2020
miniak
force-pushed
the
miniak/background-throttling-property
branch
from
1d1eebf to
bae5677
Compare
alexeykuzmin
approved these changes
May 13, 2020
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add
contents.getBackgroundThrottling()method andcontents.backgroundThrottlingpropertyChecklist
npm testpassesRelease Notes
Notes: Added
contents.getBackgroundThrottling()method andcontents.backgroundThrottlingproperty.