Skip to content

feat: support app#login event for utility process net requests#43317

Merged
codebytere merged 2 commits into
32-x-yfrom
robo/backport_app_login_utility_process_32_x_y
Aug 16, 2024
Merged

feat: support app#login event for utility process net requests#43317
codebytere merged 2 commits into
32-x-yfrom
robo/backport_app_login_utility_process_32_x_y

Conversation

@deepak1556

@deepak1556 deepak1556 commented Aug 14, 2024

Copy link
Copy Markdown
Member

Description of Change

Backport of #42631

Release Notes

Notes: Add support for responding to auth requests initiated from utility process via app#login event

* feat: support app#login event for utility process net requests

* chore: address review feedback

* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions

Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
@deepak1556 deepak1556 requested a review from a team as a code owner August 14, 2024 04:51
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Aug 14, 2024
@deepak1556 deepak1556 added semver/minor backwards-compatible functionality backport-check-skip Skip trop's backport validity checking 32-x-y labels Aug 14, 2024
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Aug 14, 2024
@deepak1556 deepak1556 added backport This is a backport PR backport-check-skip Skip trop's backport validity checking and removed backport-check-skip Skip trop's backport validity checking backport This is a backport PR labels Aug 14, 2024
@jkleinsc jkleinsc removed the backport-check-skip Skip trop's backport validity checking label Aug 14, 2024
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Aug 14, 2024
@trop trop Bot added the backport This is a backport PR label Aug 14, 2024
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Aug 14, 2024

@codebytere codebytere left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases on 15/08/2024

@codebytere codebytere merged commit 8c1be5a into 32-x-y Aug 16, 2024
@codebytere codebytere deleted the robo/backport_app_login_utility_process_32_x_y branch August 16, 2024 09:24
@release-clerk

release-clerk Bot commented Aug 16, 2024

Copy link
Copy Markdown

Release Notes Persisted

Add support for responding to auth requests initiated from utility process via app#login event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

32-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality

3 participants