fix: validate OIDs and use literal file rewrites in build-images handler#197
Merged
MarshallOfSound merged 1 commit intoJun 25, 2026
Merged
Conversation
Package metadata and webhook payload values (target_oid, the first container tag of a prior package version) were used as a regular expression and as replacement text when rewriting electron/electron workflow files. String.prototype.match compiles its string argument into a RegExp, so a crafted container tag containing regex metacharacters could match an arbitrary region of a workflow file, and the target_oid was written into the result verbatim — allowing whoever can publish package versions in electron/build-images to inject unreviewed, attacker-shaped edits into CI workflow content. Validate every OID taken from a webhook payload or package metadata against a strict 40-character hex format before use, and replace the regex-based match/replace with literal substring matching and split/join so neither value is ever interpreted as a regular expression or a replacement pattern. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PFTXnbYTesq9vibGJyDFgH
dsanders11
approved these changes
Jun 25, 2026
MarshallOfSound
deleted the
claude/autopatch-scan-1f76d7a8-vuln-1895949-3jxmwk
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package metadata and webhook payload values (target_oid, the first container tag of a prior package version) were used as a regular expression and as replacement text when rewriting electron/electron workflow files. String.prototype.match compiles its string argument into a RegExp, so a crafted container tag containing regex metacharacters could match an arbitrary region of a workflow file, and the target_oid was written into the result verbatim — allowing whoever can publish package versions in electron/build-images to inject unreviewed, attacker-shaped edits into CI workflow content.
Validate every OID taken from a webhook payload or package metadata against a strict 40-character hex format before use, and replace the regex-based match/replace with literal substring matching and split/join so neither value is ever interpreted as a regular expression or a replacement pattern.